Rhfogh xml yaml #957
Merged
Rhfogh xml yaml #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! How about we merge this to develop branch instead? This is not needed for adding YAML config files support. Let's keep the scope xml_yaml_conversation branch focused on that. |
@rhfogh I agree that this should be done on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed improvement of yaml linting. See comments in .yamllint.yaml
Note that by setting
# % YAML 1.2at the head of the files, we ensure that onlytrueandfalse(with various capitalizations) are treated as Booleans - this is what ruamel-yaml (which follows Yaml 1.2) does anyway. By keeping thetruthyrule we further limit Booleans to all-lower-case.Unfortunately there seems to be no way to ensure a single spelling for either
null,.inf, or.nanI have added further rules to block using empty elements as nulls (so nulls have to be added explicitly), and to ban numbers like
010.Anyway, I would propose that there should never be any need to put in yamllint-disable statements (except for line length).